Skip to content

Remove deprecated linter and fix issues #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Conversation

sjberman
Copy link
Collaborator

Lint workflow action uses latest golangci-lint version, so we need to fix issues.

@github-actions github-actions bot added the chore Pull requests for routine tasks label Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.84%. Comparing base (82e7591) to head (fc5759a).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/mode/static/manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2433   +/-   ##
=======================================
  Coverage   88.84%   88.84%           
=======================================
  Files         100      100           
  Lines        7527     7527           
  Branches       50       50           
=======================================
  Hits         6687     6687           
  Misses        784      784           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman marked this pull request as ready for review August 20, 2024 22:10
@sjberman sjberman requested a review from a team as a code owner August 20, 2024 22:10
@lucacome
Copy link
Contributor

Interesting that the loops were fixed in 1.22 but the linters were still complaining about the variables not being reinitialized https://go.dev/blog/loopvar-preview

@sjberman sjberman enabled auto-merge (squash) August 20, 2024 22:32
@sjberman sjberman merged commit 114275c into nginx:main Aug 20, 2024
34 of 37 checks passed
@sjberman sjberman deleted the chore/lint-fix branch August 20, 2024 22:48
miledxz added a commit to miledxz/nginx-gateway-fabric that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants