Skip to content

Run graceful recovery tests in pipeline #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 5, 2024
Merged

Run graceful recovery tests in pipeline #2045

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b59ef51
add graceful-recovery test to pipeline
salonichf5 May 29, 2024
15ad48c
fix url for routes
salonichf5 May 29, 2024
4c82953
add extra lines and remove comment
salonichf5 May 31, 2024
1f6e6b4
fix test for nplus scenarios
salonichf5 May 31, 2024
6ede9e4
check log lines for specific error
salonichf5 Jun 3, 2024
c2f1e3d
fix error check
salonichf5 Jun 3, 2024
f66d2e0
steps to reproduce intermittent error
salonichf5 Jun 4, 2024
3939f43
bypass existing upstream error in pipeline
salonichf5 Jun 4, 2024
19e3c07
correct spelling mistake
salonichf5 Jun 4, 2024
2d4d527
fix lint errors
salonichf5 Jun 5, 2024
27990ba
Merge branch 'main' into feat/automate-gracefulRecovery
salonichf5 Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint errors
  • Loading branch information
@salonichf5
salonichf5 committed Jun 5, 2024
commit 2d4d527f3a9cf6fee78ffce4d82e71a12ecea583
6 changes: 5 additions & 1 deletion tests/framework/resourcemanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,11 @@ func (rm *ResourceManager) WaitForAppsToBeReadyWithPodCount(namespace string, po
return rm.WaitForAppsToBeReadyWithCtxWithPodCount(ctx, namespace, podCount)
}

func (rm *ResourceManager) WaitForAppsToBeReadyWithCtxWithPodCount(ctx context.Context, namespace string, podCount int) error {
func (rm *ResourceManager) WaitForAppsToBeReadyWithCtxWithPodCount(
ctx context.Context,
namespace string,
podCount int,
) error {
if err := rm.WaitForPodsToBeReadyWithCount(ctx, namespace, podCount); err != nil {
return err
}
Expand Down
5 changes: 3 additions & 2 deletions tests/suite/graceful_recovery_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,10 @@ func checkContainerLogsForErrors(ngfPodName string) {
Expect(line).ToNot(ContainSubstring("[emerg]"), line)
if strings.Contains(line, "[error]") {
expectedError1 := "connect() failed (111: Connection refused)"
//FIXME(salonichf5) remove this error message check when https://github.com/nginxinc/nginx-gateway-fabric/issues/2090 is completed.
// FIXME(salonichf5) remove this error message check
// when https://github.com/nginxinc/nginx-gateway-fabric/issues/2090 is completed.
expectedError2 := "no live upstreams while connecting to upstream"
Expect(line).To(Or(Equal(expectedError1), Equal(expectedError2)))
Expect(line).To(Or(ContainSubstring(expectedError1), ContainSubstring(expectedError2)))
}
}

Expand Down