Skip to content

Nightly Conformance Tests Fail #1512

Closed
@pleshakov

Description

@pleshakov

Describe the bug
As of Jan 29 2024, nightly conformance tests fail

To Reproduce
See https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/7691006269/job/20955653116

go: finding module for package sigs.k8s.io/gateway-api/apis/v1/validation
go: github.com/nginxinc/nginx-gateway-fabric/internal/mode/static/state imports
	sigs.k8s.io/gateway-api/apis/v1/validation: package sigs.k8s.io/gateway-api/apis/v1/validation provided by sigs.k8s.io/gateway-api at latest version v1.0.0 but not at required version v1.0.1-0.20240125175351-1edf7e93ae4b
make: *** [Makefile:26: update-go-modules] Error 1
Error: Process completed with exit code 2.

Expected behavior
no failure

Your environment

Additional context
The reason for failure is Gateway API removed validation package used by Webhook.
compare:

However, we also used that package to rerun Webhook validation, according to https://github.com/nginxinc/nginx-gateway-fabric/blob/b77e9c2a42ba57f6228056d56a986eed4f531083/design/resource-validation.md

Conformance tests started failing in Dec -- https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/7204325805 -- after this was merged in the Gateway API repo kubernetes-sigs/gateway-api@052e0d1

Metadata

Metadata

Assignees

Labels

refinedRequirements are refined and the issue is ready to be implemented.testsPull requests that update tests

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions