Closed
Description
Describe the bug
As of Jan 29 2024, nightly conformance tests fail
To Reproduce
See https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/7691006269/job/20955653116
go: finding module for package sigs.k8s.io/gateway-api/apis/v1/validation
go: github.com/nginxinc/nginx-gateway-fabric/internal/mode/static/state imports
sigs.k8s.io/gateway-api/apis/v1/validation: package sigs.k8s.io/gateway-api/apis/v1/validation provided by sigs.k8s.io/gateway-api at latest version v1.0.0 but not at required version v1.0.1-0.20240125175351-1edf7e93ae4b
make: *** [Makefile:26: update-go-modules] Error 1
Error: Process completed with exit code 2.
Expected behavior
no failure
Your environment
Additional context
The reason for failure is Gateway API removed validation package used by Webhook.
compare:
- v1.0.0 -- https://github.com/kubernetes-sigs/gateway-api/tree/v1.0.0/apis/v1
- main branch (Jan 29 2024) -- https://github.com/kubernetes-sigs/gateway-api/tree/1edf7e93ae4bb8c5ea5cc2193586cfe1e5d15e2f/apis/v1
However, we also used that package to rerun Webhook validation, according to https://github.com/nginxinc/nginx-gateway-fabric/blob/b77e9c2a42ba57f6228056d56a986eed4f531083/design/resource-validation.md
Conformance tests started failing in Dec -- https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/7204325805 -- after this was merged in the Gateway API repo kubernetes-sigs/gateway-api@052e0d1