Update build files #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
lucacome
force-pushed
the
chore/build-release
branch
from
a6a73ad to
bd70324
Compare
github-actions
bot
added
the
dependencies
lucacome
force-pushed
the
chore/build-release
branch
2 times, most recently
from
17b79f6 to
dfbc510
Compare
lucacome
force-pushed
the
chore/build-release
branch
from
dfbc510 to
a330532
Compare
pleshakov
reviewed
Feb 23, 2021
| @@ -229,200 +229,6 @@ | |||
| See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
|
|
|||
| Includes the INI library (https://github.com/go-ini/ini) distributed under the following license: | |||
There was a problem hiding this comment.
do we need to add the newly added libs https://github.com/nginxinc/nginx-asg-sync/blob/master/go.sum ?
There was a problem hiding this comment.
I'm not sure how this works...like do we need to include Apache 2.0 multiple times if used by multiple libs?
There was a problem hiding this comment.
yeah, I think if we just concatenate all licenses, that would be the easiest way. What do you think?
Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
pleshakov
approved these changes
Feb 24, 2021
Dean-Coakley
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update build files before release