Skip to content

Conversation

@tellet
Copy link
Contributor

@tellet tellet commented Feb 5, 2020

Test data contains hardcoded names of scaling groups, this is a temporary decision, this can be changed to i.e a csv file that stores the details from stack configuration. The stack is considered to be the one we use for the features testing. To run these tests in a pipeline we need a stage that prepares the stack for the tests and provides the details as a test data.

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tellet thx! looks good

please see a few comments

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tellet tellet merged commit 532c98a into master Feb 7, 2020
@tellet tellet deleted the e2e-tests branch February 7, 2020 11:00
@lucacome lucacome added the chore Pull requests for routine tasks label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants