Skip to content

Refactor Redocly code to handle new theme #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2025
Merged

Refactor Redocly code to handle new theme #236

merged 2 commits into from
Feb 28, 2025

Conversation

lamATnginx
Copy link
Contributor

@lamATnginx lamATnginx commented Feb 27, 2025 •
edited
Loading

Proposed changes

Closes: https://github.com/nginxinc/docs-platform/issues/371

Screenshots below to show changes + verify it doesn't break old theme

Old:
Screenshot 2025-02-27 at 11 47 44 AM

New:
Screenshot 2025-02-27 at 11 47 19 AM

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@lamATnginx lamATnginx requested a review from a team as a code owner February 27, 2025 19:40
@lamATnginx lamATnginx self-assigned this Feb 27, 2025
@lamATnginx lamATnginx added the bug Something isn't working label Feb 27, 2025
@lamATnginx lamATnginx mentioned this pull request Feb 27, 2025
Merged
4 tasks
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/236/

@lamATnginx lamATnginx merged commit 38ba8fd into main Feb 28, 2025
8 checks passed
@lamATnginx lamATnginx deleted the fix/api-mf branch February 28, 2025 16:41
travisamartin pushed a commit that referenced this pull request Feb 28, 2025
@lamATnginx @travisamartin
Refactor Redocly code to handle new theme (#236)
edd461c 
fix: refactored api page to render with mf
travisamartin added a commit that referenced this pull request Mar 14, 2025
@travisamartin @lamATnginx @mjang
Added known issues for NIM 2.19.0 (#238)
aa13b7e 
* Added known issues for NIM 2.19.0

* edits to known issue 45845

* Refactor Redocly code to handle new theme (#236)

fix: refactored api page to render with mf

* Apply suggestions from code review

Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>

---------

Co-authored-by: Lam <150060045+lamATnginx@users.noreply.github.com>
Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nginx-jack nginx-jack nginx-jack approved these changes

Assignees

@lamATnginx lamATnginx

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamATnginx @nginx-jack