-
Notifications
You must be signed in to change notification settings - Fork 121
Add document for installing NGF on OpenShift through OperatorHub #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update compatability doc with Port for ParentRef
Update gateway addresses compatibility document.
…omment (#1126) Add a small comment on IP families to gateway addresses compatibility document.
Added mention about unsupported fields for RouteRules and Gateways Closes nginx/nginx-gateway-fabric#3784
feat: Update advanced routing guide for regex path
…cs (#1284) * Add details on BuildOS and InferencePoolCount to Product Telemetry docs * Add InferencePoolCount * Move InferencePool resource into "Count of Resources" section
✅ Deploy Preview will be available once build job completes!
|
|
Changing the base branch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mentioned a couple of nits but overall looks good. I think this branch needs a rebase with main
great job 🥳
Did you change base branch too? or only the aim of merge? I see many commits difference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly speaking, the new page needs to be restructured.
It doesn't adhere to our contemporary page standards:
- It's missing the documentation metadata
- The requirements section is not named correctly
- It uses the NGF three letter acronym: we do not use TLAs in public-facing documentation
- It uses
bashas a formatting language, whenshellhas been the norm for months - It doesn't use Hugo for list enumeration
Many of the structural issues could have been avoided by using Hugo archetypes, for which we maintain documentation which is part of the Contributing guidelines as the first item in the PR checklist.
Effectively no commits on this branch adhere to the Git conventions as the second item in the PR checklist, though this does not need to be fixed in retrospect as long as the eventual merge message is correct.
|
I made changes to the PR to reflect these points of feedback:
I'm confused by these points
The second items says
There is a Title and Description in this document. Is there other metadata missing? The most reset set of commits adds
This document doesn't have a requirements section at all, so it's not clear what you mean by this. Should we have a requirements section?
Again, not sure what this means. The Hugo Content page says As a point of feedback for the feedback, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty good. I'm guessing that go.mod and go.sum are not part of your proposed change.
Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
content/ngf/install/openshift.md
Outdated
|
|
||
| ### Create the NginxGatewayFabric custom resource | ||
|
|
||
| Create a minimal `NginxGatewayFabric` custom resource for OpenShift. Include this code in a file named `nginx-gateway-fabric.yaml`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we install the operator using the OperatorHub, this can be done in the UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it help to say "This can be done in the UI, optionally you can choose to apply the resource directly to the cluster"
Do you have an example of what that looks like in the UI? I didn't apply this in the UI when testing with OKD at the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an example, I'd need access to a cluster, but it would likely be the standard way someone would install an operand (i.e. the NGF control plane in this case).
The flow is:
Click the Create NginxGatewayFabric in the NGINX Gateway Fabric Operator tab.
Toggle the Configure via YAML view to on.
Add the YAML as specified in this example.
Click "Create"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I'll make that adjustment. Thanks @ciarams87 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ciarams87 this should be updated now
|
I have addressed everything except this in Slack.
|
| 1. Navigate to the Red Hat Catalog: https://catalog.redhat.com/en | ||
| 1. Search for "NGINX Gateway Fabric Operator" in the searchbar at the top | ||
| 1. Select NGINX Gateway Fabric Operator | ||
| 1. Select **Deploy & use**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: either periods on all bullet items or none
| 1. Select **Deploy & use**. | |
| 1. Select **Deploy & use** |
|
|
||
| ## Integrate with NGINX One Console (optional) | ||
|
|
||
| If you want to use NGINX One Console to monitor NGINX Gateway Fabric, create a secret for the dataplane key (replace VALUE with your key). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to link to our other documentation on setting up this secret / using N1c. Though this could also be fine too.
| -n nginx-gateway-fabric | ||
| ``` | ||
|
|
||
| Reference this secret in `spec.nginx.nginxOneConsole.dataplaneKeySecretName`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like more information should be given here. If NGF is already deployed, they'll need to modify the deployment flags I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually are these on the NginxGatewayFabric talked about below?
|
|
||
| ## Configure NGINX Plus licensing (optional) | ||
|
|
||
| If you plan to use NGINX Plus, set `spec.nginx.plus: true`, add image pull credentials, and create a license secret if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Proposed changes
This change adds a new page to the NGF Install section on how to install the NGF on OpenShift using the RedHat Operator Hub.
This guide also includes Operator specific configurations as well as troubleshooting.
Closes nginx/nginx-gateway-fabric#3911
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩