[NGINX Agent] Agent packaging #14
Conversation
| packageBuildNo: | ||
| type: string | ||
| default: "1" | ||
| tagRelease: |
There was a problem hiding this comment.
This input doesnt seem to be used.
| build-and-upload-packages: | ||
| name: Build and upload Agent packages | ||
| runs-on: ubuntu-24.04-amd64 | ||
| permissions: |
There was a problem hiding this comment.
Do we need to duplicate permissions here if we already have it defined on the top-most level?
| run: | ||
| shell: 'bash -Eeo pipefail -x {0}' | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
For other workflows we also have a "sanity check" job that runs on public runners - and makes sure the workflow is instantiated from our orgs and through allowed events on known branches. See e.g.
While it's probably something that isnt strictly necessary, it's an additional check to make sure our self-hosted runners wont run the jobs they're not supposed to run.
| @@ -93,12 +98,12 @@ jobs: | |||
| run: | | |||
| export PATH=$PATH:~/go/bin | |||
| echo "$GPG_KEY" | base64 --decode > ${NFPM_SIGNING_KEY_FILE} | |||
| make package | |||
| echo "Run make package -> $VERSION $PACKAGE_BUILD" | |||
There was a problem hiding this comment.
This and another hunk is probably a leftover debug?
|
Closing as more changes required, will open a new PR |
Proposed changes
Adds packaging workflow for NGINX Agent.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
README.mdand/orCHANGELOG.md).