Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualize NAP logs in mock collector grafana #939

Open
wants to merge 28 commits into
base: v3
Choose a base branch
from
Open

Visualize NAP logs in mock collector grafana #939

wants to merge 28 commits into from

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented Dec 2, 2024

Proposed changes

  • Add NAP to test NGINX Plus docker image.
  • Add Loki to mock collector

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Dec 2, 2024
@dhurley dhurley self-assigned this Dec 2, 2024
@dhurley dhurley requested a review from a team as a code owner December 2, 2024 16:08
@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 2, 2024
@oliveromahony
Copy link
Contributor

Is the make target inconsistent for build-mock-management-plane-collector and run-mock-management-otel-collector / stop-mock-management-otel-collector?

@dhurley
Copy link
Collaborator Author

dhurley commented Dec 17, 2024

Is the make target inconsistent for build-mock-management-plane-collector and run-mock-management-otel-collector / stop-mock-management-otel-collector?

I'll update them to be more consistent

@dhurley
Update NGINX plus dockerfile to always build with platform set to amd…
a65e3d3 
…64. Updated makefile target names to be more consistent.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 17, 2024
Base automatically changed from poc-v3-otel-syslog to v3 December 20, 2024 10:44
sean-breen
sean-breen reviewed Jan 8, 2025
View reviewed changes
test/mock/collector/otel-collector.yaml

processors:
batch:
resource:
Copy link

@sean-breen sean-breen Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment it looks like this will be overwritten by the other resource attributes if defined here in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-breen sean-breen sean-breen approved these changes

@craigell craigell craigell approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees

@dhurley dhurley

Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhurley @oliveromahony @craigell @sean-breen @RRashmit