Skip to content

Conversation

@dhurley
Copy link
Collaborator

@dhurley dhurley commented Jan 13, 2026

Proposed changes

Example:

data_plane_config:
  nginx:
    api:
      url: "http://127.0.0.1:80/api"

Example with socket:

data_plane_config:
  nginx:
    api:
      socket: "unix:/var/run/nginx/nginx-status.sock"
      url: "http://localhost/api"

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley requested a review from a team as a code owner January 13, 2026 16:54
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jan 13, 2026
@sjberman
Copy link

We've noticed occasional issues with agent finding the NGINX Plus API. Is this an attempt to work around that by being explicit?

@dhurley
Copy link
Collaborator Author

dhurley commented Jan 14, 2026

We've noticed occasional issues with agent finding the NGINX Plus API. Is this an attempt to work around that by being explicit?

Hi @sjberman this PR is to work around a specific use case where the server block and location block for the NGINX Plus API are in separate NGINX config files. Due to a limitation in the go-crossplane library that we use we can't construct the NGINX Plus API URL when the config is spread across multiple files.

@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Jan 14, 2026
@dhurley dhurley changed the title Add agent config option to set NGINX API URL Add agent config option to set NGINX API URL and socket path Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 59.22330% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.23%. Comparing base (a403571) to head (d3c1ebf).

Files with missing lines Patch % Lines
internal/datasource/config/nginx_config_parser.go 46.47% 31 Missing and 7 partials ⚠️
internal/config/config.go 90.00% 1 Missing and 1 partial ⚠️
internal/config/types.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
+ Coverage   85.22%   85.23%   +0.01%     
==========================================
  Files         102      102              
  Lines       12992    13060      +68     
==========================================
+ Hits        11072    11132      +60     
- Misses       1431     1436       +5     
- Partials      489      492       +3     
Files with missing lines Coverage Δ
internal/config/flags.go 100.00% <ø> (ø)
internal/config/config.go 87.45% <90.00%> (+0.01%) ⬆️
internal/config/types.go 87.09% <83.33%> (-0.56%) ⬇️
internal/datasource/config/nginx_config_parser.go 79.46% <46.47%> (+0.76%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a403571...d3c1ebf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants