-
Notifications
You must be signed in to change notification settings - Fork 106
Set a limit on the number of access logs Agent can tail #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
==========================================
+ Coverage 85.15% 85.26% +0.10%
==========================================
Files 102 102
Lines 12984 12998 +14
==========================================
+ Hits 11057 11083 +26
+ Misses 1440 1425 -15
- Partials 487 490 +3
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
aphralG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update TestResolveConfig() to also check for MaxAccessLogFiles
Proposed changes
Limit the number of access logs that Agent tails by default in order to reduce overhead. The limit can be configured in the agent conf as seen in the following example:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)