refactor: compactify checks flattening #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wegank
force-pushed
the
refactor-checks
branch
from
c386a34
to
bae1d60
Compare
wegank
approved these changes
Sep 24, 2024
this reduces repetition and increases code locality
wegank
force-pushed
the
refactor-checks
branch
from
bae1d60
to
e3c98ef
Compare
|
Huh, the rules are weird. @wegank now that you seem to have co-authored the commit, your approval isn't good enough any more. Sigh. Force-merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this reduces repetition and increases code locality