refactor flake #362
Merged
refactor flake #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fricklerhandwerk
force-pushed
the
refactor-flake
branch
from
813febf
to
eeedadb
Compare
|
Checked that this doesn't change the resulting store paths by diffing the sorted output of: nix-repl> :lf .
Added 20 variables.
nix-repl> map (x: "${x}") (builtins.attrValues checks.x86_64-linux)with the result Didn't have the time to run |
wegank
approved these changes
Sep 19, 2024
it obscured what's really happening. also skip an unnecessary import.
those namespaces are disjoint, so there's no need to obscure that they are simply joined.
the only point where we need it is for the checks. also make the naming a bit less noisy.
wegank
force-pushed
the
refactor-flake
branch
from
3ea3deb
to
4d343cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are some initial steps to eventually finish #209 and ease implementing #290
review commit by commit