Pull to refresh isn't disable on iOS #1

Activity

1. shivamsupr

   changed the title [-]Pull to refresh isn't disable in iOS[/-] [+]Pull to refresh isn't disable on iOS[/+] on Aug 5, 2018
2. nghiepdev commented on Aug 6, 2018

   

   nghiepdev

   on Aug 6, 2018

   Owner

   More actions

   Maybe the issue on the chrome recent versions.
3. Jonathan002 commented on Oct 5, 2018

   

   Jonathan002

   on Oct 5, 2018

   More actions

   This doesn't seem to work with Chrome 69.0.3497.105 on iOS 11.3. I've also tried multiple other solutions and that had seemed to work before from the reactions of others but they do not work for me for this version.

   Other solutions I've tried:

   • http://w3bits.com/prevent-chrome-pull-to-refresh-css/
   • https://stackoverflow.com/questions/50763813/disable-chromes-pull-to-refresh-on-iphone
4. apptaro commented on Nov 5, 2018

   

   apptaro

   on Nov 5, 2018

   More actions

   we need to add { passive: false } for touch move like:

   document.addEventListener('touchmove', touchmoveHandler, { passive: false });
   

   because from some version of Chrome, event listeners are default passive true.
5. nghiepdev commented on Nov 5, 2018

   

   nghiepdev

   on Nov 5, 2018

   Owner

   More actions

   @apptaro Thank for your support.
   It works!
   I just published the new patch version for the issue.
6. nghiepdev

   closed this as completedon Nov 5, 2018
7. shivamsupr commented on Nov 5, 2018

   

   shivamsupr

   on Nov 5, 2018

   Author

   More actions

   @nghiepit It's still happening just for the initial load it doesn't happen. check this https://o1l55wryq.codesandbox.io.

   To replicate:
   Scroll up once and then scroll down. You'll see pull-to-refresh.
8. apptaro commented on Nov 5, 2018

   

   apptaro

   on Nov 5, 2018

   More actions

   I know what's wrong. When a page is short, scrollling down (panning up) doesn't actually scroll the page, so scrolling up (panning down) will activate pull-to-refresh.

   https://github.com/nghiepit/prevent-pull-refresh/blob/master/index.js#L78
   here, "maybePrevent" shouldn't be set to false unless window.pageYOffset !== 0.
9. nghiepdev commented on Nov 6, 2018

   

   nghiepdev

   on Nov 6, 2018

   Owner

   More actions

   @apptaro
   Did you mean?

   const touchmoveHandler = event => {
       if (maybePrevent) {
         if (window.pageYOffset !== 0) {
           maybePrevent = false;
         }
         if (isScrollingUp(event)) {
           return event.preventDefault();
         }
       }
     };

   With me. It's still happening, same issue @shivamsupr .
   Can you help me test and make a pull request?

   Thank you in advance.
10. nghiepdev

    reopened this on Nov 6, 2018