Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resize): replace jquery.resize.js with css-element-queries #716

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

schmidtk
Copy link
Contributor

@schmidtk schmidtk commented Aug 7, 2019

BREAKING CHANGE: jquery.resize.js has a bug preventing resize listeners
from being removed, and has been replaced by css-element-queries.

  • Replace jquery.resize.js with css-element-queries in all index files
  • Replace jquery.resize.js with css-element-queries in Karma config
  • Use os.ui.resize instead of el.resize
  • Use os.ui.removeResize instead of el.removeResize

BREAKING CHANGE: jquery.resize.js has a bug preventing resize listeners
from being removed, and has been replaced by css-element-queries.
- Replace jquery.resize.js with css-element-queries in all index files
- Replace jquery.resize.js with css-element-queries in Karma config
- Use os.ui.resize instead of el.resize
- Use os.ui.removeResize instead of el.removeResize
@schmidtk schmidtk requested a review from wallw-teal August 7, 2019 19:55
@schmidtk schmidtk self-assigned this Aug 7, 2019
@schmidtk schmidtk mentioned this pull request Aug 7, 2019
@schmidtk schmidtk merged commit 01aa1de into ngageoint:master Aug 12, 2019
@schmidtk schmidtk deleted the fix-replace-jquery-resize branch August 12, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants