Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cypress): Adds end to end Cypress tests #390

Merged
merged 10 commits into from
Feb 18, 2019

Conversation

justin-bits
Copy link
Collaborator

No description provided.

@justin-bits
Copy link
Collaborator Author

I'm getting linter errors under Travis that I wasn't getting running locally. Is Travis using the latest version of eslint-config-opensphere?

Expected space or tab after '//' in comment spaced-comment will be resolved by this: ngageoint/eslint-config-opensphere#2

@justin-bits
Copy link
Collaborator Author

  • Comma between folders to be removed: "lint:js": "eslint --cache 'src/**/*.js', 'cypress/**/*.js'",
  • Need to re-run without --cache as npx eslint 'cypress/**/*.js' locally

@justin-bits justin-bits force-pushed the cypress-tests branch 3 times, most recently from eb7cfc8 to 876ccf3 Compare January 29, 2019 02:21
@justin-bits
Copy link
Collaborator Author

Should pass after this is merged: ngageoint/eslint-config-opensphere#2

@wallw-bits

@justin-bits
Copy link
Collaborator Author

Rebuilt, but still the same linter failures. It appears a new release will need to be created to pickup the changes. https://github.com/ngageoint/eslint-config-opensphere @wallw-bits

@justin-bits justin-bits force-pushed the cypress-tests branch 5 times, most recently from 0fc27ef to 6403d6d Compare January 30, 2019 22:32
Copy link
Contributor

@wallw-teal wallw-teal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GeoServer and Arc tests need to be refactored to spin up a container and hit that rather than depending on third-party services for tests (this should be easy for GeoServer, possibly less easy for Arc -- but there are better options for live servers there than a local gov one). Additionally, the state file test is also depending on a third-party server when it doesn't have to. All 3 of these tests are failing locally for me.

The smoke-tests/toolbar-right.spec.js spec is also failing for me locally. This is likely because I'm using an updated branch locally. Can you rebase/merge master on your end and verify that you get these errors?

You updated README.md, which is great. Can you also please update our readthedocs documentation under docs/ with similar instructions?

@justin-bits
Copy link
Collaborator Author

Tests should kill http-server on failure.

@justin-bits
Copy link
Collaborator Author

justin-bits commented Feb 9, 2019

Done:

  • .gitignore updated to remove references to editor
  • settings.json is now overwritten prior to test execution to ensure a known environment. This corrects a problem with tests failing due to additional servers being added by default on some developer workstations.
  • load-state-file.spec.js updated to use less a specific assertion that was causing a flaky test
  • Documentation (/docs/getting_started.rst) updated
  • Tests that fail will now kill http-server and restore the settings.json

TBD:

  • Tests are not incorporated into the build process; will only be triggered manually.

Future PR:

  • Setup docker container to eliminate the need for third party server

@wallw-teal wallw-teal merged commit a3d8d4c into ngageoint:master Feb 18, 2019
@justin-bits justin-bits deleted the cypress-tests branch February 18, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants