-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(cypress): Adds end to end Cypress tests #390
Conversation
I'm getting linter errors under Travis that I wasn't getting running locally. Is Travis using the latest version of
|
|
eb7cfc8
to
876ccf3
Compare
Should pass after this is merged: ngageoint/eslint-config-opensphere#2 @wallw-bits |
876ccf3
to
065397d
Compare
065397d
to
2cbfeb7
Compare
Rebuilt, but still the same linter failures. It appears a new release will need to be created to pickup the changes. https://github.com/ngageoint/eslint-config-opensphere @wallw-bits |
0fc27ef
to
6403d6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GeoServer and Arc tests need to be refactored to spin up a container and hit that rather than depending on third-party services for tests (this should be easy for GeoServer, possibly less easy for Arc -- but there are better options for live servers there than a local gov one). Additionally, the state file test is also depending on a third-party server when it doesn't have to. All 3 of these tests are failing locally for me.
The smoke-tests/toolbar-right.spec.js
spec is also failing for me locally. This is likely because I'm using an updated branch locally. Can you rebase/merge master on your end and verify that you get these errors?
You updated README.md
, which is great. Can you also please update our readthedocs documentation under docs/
with similar instructions?
6c38999
to
86b3278
Compare
Tests should kill http-server on failure. |
Done:
TBD:
Future PR:
|
…e the settings.json even if tes
…here into cypress-tests
No description provided.