Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify "special" in pbp dictionary #189

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Clarify "special" in pbp dictionary #189

merged 2 commits into from
Aug 1, 2023

Conversation

mrcaseb
Copy link
Member

@mrcaseb mrcaseb commented Jul 14, 2023

closes #163

@mrcaseb mrcaseb enabled auto-merge July 14, 2023 09:50
@mrcaseb mrcaseb requested a review from tanho63 July 14, 2023 09:51
@mrcaseb
Copy link
Member Author

mrcaseb commented Jul 14, 2023

Tests are failing because we don't have a 2023 roster file released

nflreadr::load_rosters(2023)
#> Warning in readRDS(con): cannot open URL
#> 'https://github.com/nflverse/nflverse-data/releases/download/rosters/roster_2023.rds':
#> HTTP status was '404 Not Found'
#> Warning: Failed to readRDS from
#> <https://github.com/nflverse/nflverse-data/releases/download/rosters/roster_2023.rds>
#> ── nflverse  ───────────────────────────────────────────────────────────────────
#> Null data.table (0 rows and 0 cols)

Created on 2023-07-14 with reprex v2.0.2

@tanho63 tanho63 disabled auto-merge August 1, 2023 15:29
@tanho63 tanho63 merged commit 6fbfe51 into main Aug 1, 2023
5 of 6 checks passed
@tanho63 tanho63 deleted the data-dict-special branch August 1, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change the desc of special?
2 participants