Skip to content

Conversation

potench
Copy link
Contributor

@potench potench commented Jan 2, 2018

Fixes #29

Change Log
(fix) remove an unnecessary import of createManagerTest.js in index.js - fixes unnecessary bundling of mockGPT and createManagerTest in production bundle.

Test Plan

  1. npm run build
  2. Review dist/react-gpt.js to ensure createManagerTest and mockGPT are not imported.
  3. npm run test run tests to make sure everything still works

@codecov
Copy link

codecov bot commented Jan 2, 2018

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files           8        8           
  Lines         580      580           
=======================================
  Hits          539      539           
  Misses         41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d14cd...266594c. Read the comment docs.

@potench
Copy link
Contributor Author

potench commented Jan 2, 2018

After this change:
bundlesize — ./dist/react-gpt.min.js: 8.39kB < maxSize 10.5kB gzip
Updated bundlesize to reflect change

@potench potench merged commit 27187e0 into master Jan 4, 2018
@potench potench deleted the issues/29 branch January 4, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mockGPT.js should not be in production bundle
2 participants