Skip to content

Fix modules and subworkflows search pagination #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lmReef
Copy link
Contributor

@lmReef lmReef commented Mar 25, 2025

Re-opening this as the issue seems to have persisted through the svelte 5 upgrade

Closes #2883
Old PR: #3089

Old PR Desc:

Fix modules search pagination issue

Overview

Fixes an issue where browsing modules on https://nf-co.re/modules/ sometimes shows blank search results.
This fix simply sets the currentPage = 1 for the paginator each time the SearchQuery is updated.

Closes #2883

Presumably the subworkflows page has the same issue that will be fixed by this, but it has another bug on top of that (#2942) preventing testing which I'll have a look at in another PR

Steps to reproduce

  1. navigate to https://nf-co.re/modules/
  2. go to page 2 of the results (or any page for that matter)
  3. search something with limited results such as abs (which only has 1 result)
  4. result is that search results are filtered down and fit on page 1, however user is left on whichever page they were on before
  5. confirm this is the case by clicking previous button until back on page 1 where you can see the results

@lmReef lmReef added the bug Something isn't working label Mar 25, 2025
@lmReef lmReef requested a review from mashehu March 25, 2025 03:03
@lmReef lmReef self-assigned this Mar 25, 2025
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for nf-core-docs ready!

Name Link
🔨 Latest commit e4992f2
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-docs/deploys/67e21d04b7a1920008d2d82a
😎 Deploy Preview https://deploy-preview-3270--nf-core-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit e4992f2
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-main-site/deploys/67e21d0461bebf0008dc4de7
😎 Deploy Preview https://deploy-preview-3270--nf-core-main-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-project-automation github-project-automation bot moved this from To do to In progress in Hackathon March 2025 Apr 10, 2025
@mashehu mashehu merged commit ebd79eb into nf-core:main Apr 10, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Hackathon March 2025 Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Pagination in modules list does not reset on short search output
2 participants