Start september/october maintainer minutes #2819
Open
+145
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mashehu
reviewed
Oct 27, 2024
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
mashehu
reviewed
Oct 27, 2024
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
mashehu
reviewed
Oct 27, 2024
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
|
@nf-core-bot fix linting |
sateeshperi
reviewed
Oct 27, 2024
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
| It was raised that regularly get almost-complete module PRs, but sometimes they stall because a reviewer leaves comments but does not come back to re-review. | ||
| Even if the module author receives a second approving review, but the author often (because we are nice here at nf-core) doesn't feel comfortable merging without getting the approval from the original reviewer. | ||
|
|
||
| After a short discussion we felt that we can add a new reviewing guideline that if all (reasonable) comments have been addressed, and an approval has been given by another reviewer, a PR should be merged after 3 months if the original reviewer did not re-review. |
There was a problem hiding this comment.
Suggested change
| After a short discussion we felt that we can add a new reviewing guideline that if all (reasonable) comments have been addressed, and an approval has been given by another reviewer, a PR should be merged after 3 months if the original reviewer did not re-review. | |
| After a brief discussion, we agreed to introduce a new reviewing guideline: if all reasonable comments have been addressed and another reviewer has approved, the PR should be merged after 3 months if the original reviewer has not returned for a re-review. |
There was a problem hiding this comment.
im thinking maybe 3 months is too long ?? how about 1 month instead ? as I fear if this a nf-core beginner adopter and if they have to report back to their work that can't get it done for another 3 months they might lose interest
There was a problem hiding this comment.
Also wasn't the problem her the author not the reviewer?
There was a problem hiding this comment.
well if an author delays, thats their issue I guess. I think the point here is if nf-core reviewers delay the complete review
There was a problem hiding this comment.
the discussion arose around nf-core/modules#5706, where the module maintainer didn'didn't come back to a PR changing things in their module.
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
sateeshperi
reviewed
Oct 27, 2024
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Show resolved
Hide resolved
sateeshperi
reviewed
Oct 27, 2024
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
sateeshperi
reviewed
Oct 27, 2024
sites/main-site/src/content/blog/2024/maintainers-minutes-2024-10-25.mdx
Outdated
Show resolved
Hide resolved
|
@nf-core-bot fix linting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maxulysse I've added some empty places for you to edit :)
@netlify /blog/2024/maintainers-minutes-2024-10-25