Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cloud testing matrix strategy #1378
Improve cloud testing matrix strategy #1378
Changes from 9 commits
c081571
79fd632
7c81a4a
5b2cad0
e2778aa
0420159
3347823
2aff87c
a328f6d
176b50d
f338898
1275645
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm does this turn of that they are run automatically on release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The whole workflow is triggered by:
If manual, there is an
inputs
item which includes these variables. When it runs, it checks theinputs
item for thematrix.test
andmatrix.cloud
key, e.g. ifmatrix.test = azure
, it checksinputs.azure
is false, based on manual setting, then negates it. This means if it is true, the test will run. If the workflow is automatically triggered,inputs
does not exist and it will not findinputs.azure
, therefore the test will run.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having said that, I actually have no way of testing this automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then let's merge that, and we'll test
This file was deleted.