Skip to content

Update to pixelator 0.20.x #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

johandahlberg
Copy link
Collaborator

This is PR brings the changes to the pipeline to support the Proximity Network Assay (PNA) from Pixelgen Technologies. It splits the pipeline into two subworkflows, the existing one for MPX and a new one for PNA.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/pixelator branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.1.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@johandahlberg johandahlberg requested a review from fbdtemme April 17, 2025 11:37
@johandahlberg johandahlberg force-pushed the update-to-pixelator-0.20.x branch from 942a76d to dc26752 Compare May 6, 2025 14:15
@johandahlberg johandahlberg marked this pull request as ready for review May 16, 2025 08:38
Copy link
Collaborator

@fbdtemme fbdtemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a bunch of pedantic formatting stuff 🙂

Comment on lines 11 to 13
path "design_options.txt", emit: designs
path "panel_options.txt", emit: panels
path "versions.yml", emit: versions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment 🙂

Comment on lines 16 to 18
tuple val(meta), path("amplicon/*.report.json"), emit: report_json
tuple val(meta), path("amplicon/*.meta.json"), emit: metadata
tuple val(meta), path("*pixelator-amplicon.log"), emit: log
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing alignment

Comment on lines 14 to 21
tuple val(meta), path("analysis/*dataset.pxl"), emit: dataset
tuple val(meta), path("analysis/*report.json"), emit: report_json
tuple val(meta), path("analysis/*.meta.json"), emit: metadata
tuple val(meta), path("analysis/*"), emit: all_results
tuple val(meta), path("*pixelator-analysis.log"), emit: log

path "versions.yml" , emit: versions
path "versions.yml", emit: versions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing alignment

Comment on lines 14 to 20
tuple val(meta), path("annotate/*.dataset.pxl"), emit: dataset
tuple val(meta), path("annotate/*.report.json"), emit: report_json
tuple val(meta), path("annotate/*.meta.json"), emit: metadata
tuple val(meta), path("annotate/*"), emit: all_results
tuple val(meta), path("*pixelator-annotate.log"), emit: log

path "versions.yml" , emit: versions
path "versions.yml", emit: versions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing alignment

Comment on lines 16 to 20
tuple val(meta), path("collapse/*.report.json"), emit: report_json
tuple val(meta), path("collapse/*.meta.json"), emit: metadata
tuple val(meta), path("*pixelator-collapse.log"), emit: log

path "versions.yml" , emit: versions
path "versions.yml", emit: versions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment

Comment on lines 12 to 20
path amplicon_data, stageAs: "results/amplicon/*"
path preqc_data, stageAs: "results/preqc/*"
path adapterqc_data, stageAs: "results/adapterqc/*"
path demux_data, stageAs: "results/demux/*"
path collapse_data, stageAs: "results/collapse/*"
path graph_data, stageAs: "results/graph/*"
path annotate_data, stageAs: "results/annotate/*"
path analysis_data, stageAs: "results/analysis/*"
path layout_data, stageAs: "results/layout/*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stageAs alignment

Comment on lines 23 to 25
tuple val(meta), path("report/*.html"), emit: reports
tuple val(meta), path("*pixelator-*.log"), emit: log
path "versions.yml", emit: versions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment

Comment on lines 13 to 19
path amplicon_data, stageAs: "results/amplicon/*"
path demux_data, stageAs: "results/demux/*"
path collapse_data, stageAs: "results/collapse/*"
path graph_data, stageAs: "results/graph/*"
path analysis_data, stageAs: "results/analysis/*"
path post_analysis_data, stageAs: "results/post_analysis/*"
path layout_data, stageAs: "results/layout/*"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment

@@ -129,12 +128,12 @@ workflow GENERATE_REPORTS {
ch_report_inputs.graph,
ch_report_inputs.annotate,
ch_report_inputs.analysis,
ch_report_inputs.layout
ch_report_inputs.layout,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the trailing comma's here work? I thought it wasn't allowed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. But I will remove it just to be sure.

workflow PNA {
take:
fastq // channel: [ meta, [path(sample_1.fq), path(sample_2.fq)] ]
panel_files // channel [ meta, path(panel_file) | ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
panel_files // channel [ meta, path(panel_file) | ]
panel_files // channel: [ meta, path(panel_file) | ]

@johandahlberg johandahlberg merged commit 5d276ea into nf-core:dev May 19, 2025
33 checks passed
@fbdtemme fbdtemme mentioned this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants