-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 1.1.0 - Schmuddlweddr #179
Conversation
Update from Master to add DOI
Update modules gfaffix, MultiQC, samtools/faidx
Update `vg deconstruct` to v1.50.1
update smoothxg to v0.7.1
also put DRAW into MultiQC report
another MultiQC fix
Update modules odgi and wfmash
Important! Template update for nf-core/tools v2.13
prepare 1.1.0 release - Schmuddlweddr
|
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Some fixes for the release
Alright, I think I addressed everything @mashehu. Thanks for the detailed feedback :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, very minor changes requested, and one question about the DOI in the terminal output.
Test runs succeed for me, tested with Docker on EC2 linux and osx
$ nextflow run main.nf -profile docker,test --outdir test-results
N E X T F L O W ~ version 23.04.3
Launching `main.nf` [soggy_davinci] DSL2 - revision: a4c3964401
Downloading plugin nf-validation@1.1.3
WARN: Access to undefined parameter `monochromeLogs` -- Initialise it to a default value eg. `params.monochromeLogs = some_value`
------------------------------------------------------
,--./,-.
___ __ __ __ ___ /,-._.--~'
|\ | |__ __ / ` / \ |__) |__ } {
| \| | \__, \__/ | \ |___ \`-._,-`-,
`._,._,'
nf-core/pangenome v1.1.0
------------------------------------------------------
...
[4d/27b1c4] process > NFCORE_PANGENOME:PANGENOME:MULTIQC [100%] 1 of 1 ✔
-[nf-core/pangenome] Pipeline completed successfully-
Completed at: 27-Feb-2024 11:42:47
Duration : 2m 46s
CPU hours : (a few seconds)
Succeeded : 22
Thanks @heuermh! If you are happy now, please approve ;) |
Very happy, thank you! 😁 |
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).