Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shinyngs modules to latest to resolve palette issues #65

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Update shinyngs modules to latest to resolve palette issues #65

merged 1 commit into from
Feb 10, 2023

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Feb 10, 2023 •
edited
Loading

This PR updates the shinyngs modules to incorporate a recent plotting fix in differential.

closes #59

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Feb 10, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit b4f9be5

+| ✅ 158 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-02-10 11:11:11

@pinin4fjords pinin4fjords requested a review from WackerO February 10, 2023 11:50
@pinin4fjords pinin4fjords linked an issue Feb 10, 2023 that may be closed by this pull request
Differential plotting fails where there are no differential genes #59
Closed
@pinin4fjords
Copy link
Member Author

Thanks @mashehu !

@pinin4fjords pinin4fjords merged commit 82a8472 into nf-core:dev Feb 10, 2023
@pinin4fjords pinin4fjords deleted the shinyngs_bump branch February 10, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@WackerO WackerO Awaiting requested review from WackerO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Differential plotting fails where there are no differential genes
2 participants
@pinin4fjords @mashehu