Skip to content

Conversation

HDash
Copy link
Member

@HDash HDash commented Sep 10, 2025

Fixes #293

The bug and its fix are all detailed in the issue above.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    NA
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    NA
  • If necessary, also make a PR on the nf-core/cutandrun branch on the nf-core/test-datasets repository.
    NA
  • Make sure your code lints (nf-core lint).
    NA: PR change does not affect existing lint status
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
    NA
  • Output Documentation in docs/output.md is updated.
    NA
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@HDash HDash requested a review from Copilot September 10, 2025 14:37
@HDash HDash self-assigned this Sep 10, 2025
@HDash HDash added the bug Something isn't working label Sep 10, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a logic error in linear deduplication where reads with the lowest MAPQ scores were being kept instead of the highest quality reads. The fix includes a version bump and changelog update to document the correction.

  • Fixed logic error in linear deduplication functionality
  • Updated version from 3.2.2 to 3.2.3
  • Added changelog entry documenting the bug fix

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
nextflow.config Bumped version number from 3.2.2 to 3.2.3
CHANGELOG.md Added new version entry documenting the deduplication logic fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @HDash,

It looks like this pull-request is has been made against the HDash/cutandrun master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the HDash/cutandrun dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@HDash HDash changed the base branch from master to dev September 10, 2025 14:39
@HDash HDash marked this pull request as ready for review September 10, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

find_unique_reads.py keeps lower-scoring duplicates instead of highest MAPQ

2 participants