[3/5] dataclass_transform
#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
dataclass-transform
branch
from
b91d87b to
a9e11e7
Compare
dandavison
force-pushed
the
type-assertions
branch
from
775285c to
d164ae4
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
a9e11e7 to
fc753cf
Compare
dandavison
force-pushed
the
type-assertions
branch
from
d164ae4 to
9679865
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
fc753cf to
4e78ff3
Compare
dandavison
force-pushed
the
type-assertions
branch
from
9679865 to
4d2cbbe
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
4e78ff3 to
f44be30
Compare
dandavison
force-pushed
the
type-assertions
branch
from
4d2cbbe to
a7970dc
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
f44be30 to
47219c7
Compare
dandavison
force-pushed
the
type-assertions
branch
from
a7970dc to
912ea11
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
47219c7 to
4af2252
Compare
dandavison
force-pushed
the
type-assertions
branch
from
912ea11 to
97376d2
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
4af2252 to
d461e2c
Compare
dandavison
force-pushed
the
type-assertions
branch
from
97376d2 to
13b24d4
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
d461e2c to
48b5b5c
Compare
dandavison
force-pushed
the
type-assertions
branch
from
13b24d4 to
25aebe9
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
48b5b5c to
b65bae0
Compare
dandavison
force-pushed
the
type-assertions
branch
from
25aebe9 to
12ceb41
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
b65bae0 to
27110ec
Compare
dandavison
force-pushed
the
type-assertions
branch
from
12ceb41 to
1dd575e
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
27110ec to
4cd141d
Compare
cretz
reviewed
Jul 14, 2025
| my_op: nexusrpc.Operation[None, None] | ||
|
|
||
| @service_handler(service=SD) | ||
| class SH: |
There was a problem hiding this comment.
Are these reportUnusedClass and reportUnusedParameter issues valid? If not, we should consider disabling them for test due to noise.
Contributor
Author
There was a problem hiding this comment.
I'm still thinking about that. I'm tempted to make the codebase compliant, e.g. using underscore-prefixed variable names where they are intentionall not used.
Contributor
Author
There was a problem hiding this comment.
I've silenced all "unused thing" warnings at #18, and allowed pyright to fail if there are any warnings.
dandavison
force-pushed
the
type-assertions
branch
from
1dd575e to
1d43557
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
4cd141d to
32318d5
Compare
dandavison
force-pushed
the
type-assertions
branch
from
1d43557 to
76241b2
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
32318d5 to
02397dd
Compare
cretz
approved these changes
Jul 14, 2025
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Looks like all of the warnings are addressed in another PR
dandavison
force-pushed
the
type-assertions
branch
from
76241b2 to
6e7bdd3
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
02397dd to
cb4777e
Compare
AI: This commit should have tag name type-assertions and should be force-pushed to a branch of that name as necessary.
AI: This commit should have tag name dataclass-transform and should be force-pushed to a branch of that name as necessary.
dandavison
force-pushed
the
type-assertions
branch
from
6e7bdd3 to
f6d4657
Compare
dandavison
force-pushed
the
dataclass-transform
branch
from
cb4777e to
9c06a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR 3/5 in a stack.
Fixes #12.
We use dataclass_transform to address the problem described in the issue, copied below.
Defining an operation in a service contract definition fails pyright's reportUninitializedInstanceVariable check with a message like
While this check is off by default in Pyright and Pylance (VSCode), it will be seen by users of Cursor and
basedpyrightunless they have disabled it.