-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to adjust the matrix padding in a sequencer? #150
Comments
Anyone know how to fix this? |
I am looking into this and thinking about it. It currently isn't possible but there should be a way of making it available without overcomplicating the component for people that don't need to use it. PRs or ideas welcome. |
Inside sequencer.js file there is a class called MatrixCell with method called sizeInterface():
If you look at the generated html you can see that sequencer(matrix) consists of svg elements (rects).
We can accept padding as parameter and use that value inside:
and
so that width & height of the rects would be svg.width - 2 * padding, svg.height - 2 * padding thus effectively creating the padding |
I am attempting to fix this but only have made a partial fix. The way I have done it you can now add padding but it changes the button size. Maybe someone can look at what i've done and give me some advice. I am still learning a lot of the library. and see the example for it in use:
|
@tatecarson |
Created pr for this. |
This was fixed with #178. Does this work for you @rohitkrishna094 ? I am going to close for now and you can comment again if you feel the need. |
* updated discord message * feat: support for vertical orientation (#115) * fix: Nexus.tune.createScale() does not produce expected scale (#138) * fix: numberOfSliders does not change number of sliders for Multislider (#161) * feat: support for vertical orientation (#115) * feat: add padding to sequencer (#150) #178 * feat: add padding to sequencer (#150) #178 * removed commented out line * chore(release): 2.1.0 * chore(release): 2.1.1 * chore(release): 2.1.2 * add build * fix issue #161 * modify regex to support input of negative numbers to number component * update dist after regex change * chore(release): 2.1.3 * 🐛 Fix Nexus.Interval import regression * Fix Nexus.Interval import regression #184 * chore(release): 2.1.4 * Implement multi-touch piano * chore(release): 2.1.5 * Remove document.write * Rebuild dist files * Fix broken CSS in examples * Bump websocket-extensions from 0.1.3 to 0.1.4 (#185) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump standard-version from 7.1.0 to 8.0.1 (#187) Bumps [standard-version](https://github.com/conventional-changelog/standard-version) from 7.1.0 to 8.0.1. - [Release notes](https://github.com/conventional-changelog/standard-version/releases) - [Changelog](https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md) - [Commits](conventional-changelog/standard-version@v7.1.0...v8.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Reduce dependency on web audio (#190) * Only create AudioContext when necessary * Tweak npm version * Rebuild dist files * update documention cdn to use latest build * fixed mistake * fixed main and build * "chore(release): 2.1.6" * Update index.html trying to get it to rebuild Co-authored-by: Vladan Sarac <vladan.sarac.pv@gmail.com> Co-authored-by: jamesstaub <james.staub@gmail.com> Co-authored-by: Theis Bazin <theis.bazin@outlook.com> Co-authored-by: Andy Harman <andyh.at.pendragon@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andy Harman <pendragon-andyh@users.noreply.github.com>
In the example below, how do I add more padding between rows or columns in sequencer matrix?
Here is the code snippet that I am using:
The cells are too close to one another and I want them more spaced out and want to add different padding for rows and columns. How can I do that?
Thanks
The text was updated successfully, but these errors were encountered: