Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: phylo: clean rule removes the USVI data #38

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix: phylo: clean rule removes the USVI data #38

merged 1 commit into from
Feb 27, 2024

Conversation

j23414
Copy link
Contributor

@j23414 j23414 commented Feb 26, 2024

Description of proposed changes

Update the clean rule such that it does not remove USVI data.

Related issue(s)

Checklist

  • Checks pass

@j23414 j23414 requested a review from a team February 26, 2024 19:04
@j23414 j23414 linked an issue Feb 26, 2024 that may be closed by this pull request
phylo: clean rule removes the USVI data #37
Closed
joverlee521
joverlee521 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The workflow usually outputs intermediate files to results/ so I'm not too concerned about this needing to be updated in the future. Also allows us to hold other arbitrary files in data/ without worrying about them getting removed 😄

@j23414 j23414 merged commit 70a9f8c into main Feb 27, 2024
32 checks passed
@j23414 j23414 deleted the 37-phylo-clean-rule-removes-the-usvi-data branch February 27, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joverlee521 joverlee521 joverlee521 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

phylo: clean rule removes the USVI data
2 participants
@j23414 @joverlee521