Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc tpyoes #41

Merged
merged 6 commits into from
May 16, 2024
Merged

Misc tpyoes #41

merged 6 commits into from
May 16, 2024

Conversation

genehack
Copy link
Contributor

Description of proposed changes

This fixes various typos, misspellings, grammatical issues that I noticed while reading through the repository. It also contains a few additions or rephrasing.

I have structured this so that each type of change is in a single commit, so that if any of the changes are objectionable or undesired, rebasing them out should be trivial.

@genehack genehack requested review from joverlee521 and a team May 16, 2024 16:34
ingest/defaults/config.yaml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Also link to `HEAD` version to allow for main branch renaming
schnanighans.
@genehack
Copy link
Contributor Author

Pushed both those changes (linking to ncov Changelog and adding the scare quotes around mnemonic)

@tsibley
Copy link
Member

tsibley commented May 16, 2024

FWIW, our typical process would often be to fix up (in the git rebase sense) changes like those into the original commits. (But fine to leave them as-is here.)

@genehack
Copy link
Contributor Author

FWIW, our typical process would often be to fix up (in the git rebase sense) changes like those into the original commits. (But fine to leave them as-is here.)

👍 $JOB[-1] had a "warts and all" history preservation policy, but I actually prefer the rebase way, I'll switch.

@genehack genehack merged commit f33c43e into main May 16, 2024
@genehack genehack deleted the misc-tpyoes branch May 16, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants