-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node version 14 #438
Use node version 14 #438
Conversation
The currently used node version `13` [has already reached end-of-life status](https://github.com/nodejs/Release#end-of-life-releases) and is preventing auspice npm updates from working on nextstrain.org (#437, nextstrain/auspice@bec41d6) Choice of `14` is mostly due to consistency as it is already used in GitHub actions: - [update-dataset-listings](https://github.com/nextstrain/nextstrain.org/blob/04acaaffe766274ded930b6cafc55b75df8c1311/.github/workflows/update-dataset-listings.yml#L16) - [update-search](https://github.com/nextstrain/nextstrain.org/blob/04acaaffe766274ded930b6cafc55b75df8c1311/.github/workflows/update-search.yml#L22) Also updating npm version to 6.14.x since it corresponds with node=14 per https://nodejs.org/en/download/releases/.
5c377d6
to
6af3deb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Here's the build log from the Heroku review app:
-----> Installing binaries
engines.node (package.json): ^14
engines.npm (package.json): ^6.14
Resolving node version ^14...
Downloading and installing node 14.18.1...
Bootstrapping npm ^6.14 (replacing 6.14.15)...
npm ^6.14 installed
P.S. Consistency is good, however if there's reasons to use node 16 over node 14 then I'd be be happy to do that across the board here. I know that performance improved in nodejs 16, but whether that would be noticeable for us I'm not sure. |
@jameshadfield I think we should definitely move to node 16 at some point, the earlier the better. We can first merge this then have another PR to upgrade package.json + GitHub actions simultaneously. Also, this is specifically for nextstrain.org. For auspice, we should maintain compatibility with a set of actively supported node versions for more consumption flexibility. That's what I'm hoping to do with nextstrain/auspice#1436. Summary: node versions in package.json and GitHub actions should be consistent per repo. |
🎉 |
Hmm looks like I missed out on a couple references: I'll make another PR for those. |
The currently used node version
13
has already reached end-of-life status and is preventing auspice npm updates from working on nextstrain.org (#437, nextstrain/auspice@bec41d6)Choice of
14
is mostly due to consistency as it is already used in GitHub actions:Also updating npm version to 6.14.x since it corresponds with node=14 per https://nodejs.org/en/download/releases/.
Syntax reference for
^14
,^6.14