dataset-select filter by contributor #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eharkins
force-pushed
the
filter-contributor
branch
from
ba757f5
to
ec257c3
Compare
|
Second commit makes contributor filters distinct from keyword ones. They show up like |
eharkins
force-pushed
the
filter-contributor
branch
from
ec257c3
to
a430c9e
Compare
Columns are currently supplied to the <DatasetSelect> for rendering in a table. Here we also expose these as filtering options. The first column (the dataset) is special cased and broken into keywords, thus allowing (e.g.) us to match "h3n2" for a dataset flu/seasonal/h3n2/ha/2y. This commit rebases previous work by @harkins onto a refactored version of the <DatsetSelect>, and extends it to require datasets to match the union of filterValues for each filterType specified. Co-authored-by: eharkins <eli.harkins@gmail.com>
jameshadfield
force-pushed
the
filter-contributor
branch
from
a430c9e
to
8d0e739
Compare
|
I am going to merge this (and the parent etc) so that #299 ends up with all the related changes, and we can perform final review / testing there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the dataset contributor as a keyword for the filtering of datasets in the dataset-select component. In some cases this results in duplicate or near-duplicate keywords if the contributor name is also in the dataset name.
It doesn't add contributor keywords if the datasets are all from the same contributor.