Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title case hyphen issue #144

Merged

Conversation

wlaurance
Copy link
Contributor

Description of proposed changes

What is the goal of this pull request? What does this pull request change?

Adds support for anchorText in posts. This allows the author to customize the anchor text in the left hand menu.

image

Related issue(s)

Fixes #137

Testing

What steps should be taken to test the changes you've proposed?
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?

This change can be tested by visually inspecting the site.

Thank you for contributing to Nextstrain!

cc @chrisq21 I started working on this PR without looking at the comments yesterday. Happy to go with your solution. But I figured I'd share mine just in case! thanks

@wlaurance wlaurance force-pushed the wlaurance-title-case-dashes branch from db871b7 to 2aa3938 Compare April 1, 2020 02:34
@chrisq21
Copy link

chrisq21 commented Apr 1, 2020

@wlaurance No worries! I like this approach

@jameshadfield jameshadfield temporarily deployed to nextstrain-s-wlaurance--hknb2v April 2, 2020 02:30 Inactive
@jameshadfield jameshadfield self-requested a review April 8, 2020 22:28
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice solution as this let's us manually define sidebar text (anchorText) as we desire :)

@jameshadfield jameshadfield merged commit 65f1773 into nextstrain:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Hyphens in SARS-CoV-2 help page titles are replaced by spaces in the sidebar nav
3 participants