Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): trigger nextstrain/docker-base rebuild on release #1505

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

ivan-aksamentov
Copy link
Member

@ivan-aksamentov ivan-aksamentov commented Jul 5, 2024

Resolves #652

Other changes made:

  • Added nextclade to list of repos that have permission to use org secret GH_TOKEN_NEXTSTRAIN_BOT_WORKFLOW_DISPATCH

Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nextclade ✅ Ready (Inspect) Visit Preview Jul 9, 2024 6:37pm

@ivan-aksamentov
Copy link
Member Author

How do we test that?

@ivan-aksamentov
Copy link
Member Author

I guess we can just wait and see whether ti works on next release

Copy link
Member

@victorlin victorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rebuild was triggered by the new workflow. Looks good. Let's check if the release trigger works as expected during the next release.

I've force-pushed to drop 9bd5fc5. Feel free to reword or squash b1aa56a into your other commit.

victorlin and others added 2 commits July 9, 2024 11:27
The activity type released¹ more directly matches the desire here:

> A release was published, or a pre-release was changed to a release.

¹ <https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=released#release>
@victorlin victorlin force-pushed the chore/ci-trigger-docker-base branch from 2a1cbe8 to c6e3258 Compare July 9, 2024 18:29
@victorlin
Copy link
Member

victorlin commented Jul 9, 2024

I did some testing and realized what I wrote in b1aa56a is incorrect. I've reworded in 85e2479

@ivan-aksamentov ivan-aksamentov merged commit 31c64b3 into master Jul 10, 2024
20 checks passed
@ivan-aksamentov ivan-aksamentov deleted the chore/ci-trigger-docker-base branch July 10, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebuild nextstrain/base Docker image automatically?
2 participants