Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pathogen-embed to the base image #221

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Add pathogen-embed to the base image #221

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
931e134
Add pathogen-embed to the base image
huddlej Jun 20, 2024
3adc53c
Copy installed Python scripts to final image
huddlej Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ RUN if [[ "$TARGETPLATFORM" == linux/arm64 ]]; then \
; \
fi

RUN pip3 install pathogen-embed==2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non-blocking)

Noting from the run summary that this added 8.5 minutes to the build time:

[linux/arm64] RUN pip3 install pathogen-embed==2.0.0     | 496.7s (61.9%)  ████████████████████
[linux/amd64] RUN pip3 install pathogen-embed==2.0.0     | 17.0s (2.1%)    ▋

I'm not worried since this dependency is pinned, meaning the cached result will be used most of the time and that the increased build time would only be noticeable during (infrequent) cache misses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one change also adds ~57 MB to the image file size... 😕

I expected an increase, since we need to install scikit-learn, HDBSCAN, and UMAP, but it is kind of a bummer.


# 2. Add unpinned programs

Expand Down