Skip to content

Commit

Permalink
[simplify maintainence] Remove bin/scripts duplication
Browse files Browse the repository at this point in the history
If a script does not need to be modified for a pathogen ingest, pull
script during runtime instead of maintaining a potentially diverging
copy.

https://www.oreilly.com/library/view/building-maintainable-software/9781491955987/ch04.html

Use a permalink for each script to allow us to version the software we
use in this workflow without being affected by upstream changes until
we want to bump the version. This design adds more maintenance to this
workflow, but it also protects users against unexpected issues that are
outside of their control.
Discussed in nextstrain/ebola#6 (comment)

However, this commit gets reverted later based on discussions.
  • Loading branch information
j23414 authored and j23414 committed May 5, 2023
1 parent 854bab8 commit 67e01b9
Show file tree
Hide file tree
Showing 30 changed files with 138 additions and 1,466 deletions.
234 changes: 0 additions & 234 deletions ingest/bin/apply-geolocation-rules

This file was deleted.

42 changes: 0 additions & 42 deletions ingest/bin/cloudfront-invalidate

This file was deleted.

17 changes: 0 additions & 17 deletions ingest/bin/csv-to-ndjson

This file was deleted.

34 changes: 0 additions & 34 deletions ingest/bin/download-from-s3

This file was deleted.

Loading

0 comments on commit 67e01b9

Please sign in to comment.