Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify CI target in a Snakemake rule #17

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Specify CI target in a Snakemake rule #17

merged 1 commit into from
Apr 27, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Apr 25, 2024

Description of proposed changes

Previously, updates to build names prompted tedious changes in downstream CI usage, such as:

Now, such changes only require updates within this pathogen repo.

Related issue(s)

Checklist

  • Make PRs on downstream repos to use this new target
  • Checks pass

Previously, updates to build names prompted tedious changes in
downstream CI usage, such as:

- nextstrain/augur@ef79e16
- nextstrain/docker-base@ebe2e55
- nextstrain/conda-base@2cda9b0

Now, such changes only require updates within this pathogen repo.

Co-authored-by: Jover Lee <joverlee521@gmail.com>
@trvrb
Copy link
Member

trvrb commented Apr 27, 2024

Thanks @victorlin! I wasn't aware of all the moving parts for CI to happen. This is definitely cleaner.

@trvrb trvrb merged commit c0c24ac into master Apr 27, 2024
6 checks passed
@trvrb trvrb deleted the victorlin/ci-target branch April 27, 2024 23:39
@joverlee521 joverlee521 mentioned this pull request Jul 16, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants