Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download: use the node.shell.inView property #1681

Merged
merged 1 commit into from
Aug 20, 2023

Commits on Jul 27, 2023

  1. download: use the node.shell.inView property

    The `node.inView` property is a temporary hold for the node's inView
    property to be able to zoom in on specific branches before the
    D3 PhyloTree has been constructed.
    
    Once the D3 PhyloTree has been constructed, the inView property is
    available through `node.shell.inView`. This is the property that gets
    updated by `applyInViewNodesToTree` whenever the user interacts with
    any zooming functionality on the tree. The temporary `node.inView`
    property will never be updated and thus only represents the initial
    state of the node when the tree was first loaded.
    
    Therefore, any downstream uses of the inView property should be using
    the `node.shell.inView` property.
    joverlee521 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    8304cdf View commit details
    Browse the repository at this point in the history