Bump supported pyfastx versions #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
commented
Nov 7, 2023
The motivation is that version 0.9.0 added support for Python 3.10 and 3.11¹, which we want to support for Augur. However, 0.9.0 also introduced a bug that prevented access by sequence ID. This was fixed in version 1.0.0.² Looking at the rest of the changelog, I don't see any other breaking changes through the current version (2.0.1), at least for Augur's use case. Assuming this will hold true for other 2.x versions, allow both major versions 1 and 2. ¹ https://github.com/lmdu/pyfastx/blob/ee7303d1402d5f83db1a6ec74b5140b912ae75bb/docs/changelog.rst ² lmdu/pyfastx#62
As noted in the resolved TODO.
victorlin
force-pushed
the
victorlin/bump-pyfastx
branch
from
b045099
to
dcb5e80
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
joverlee521
approved these changes
Nov 7, 2023
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See commit messages.
Related issue(s)
Checklist