Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter: Expand comment and testing for --query #1282

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Aug 16, 2023

Description of proposed changes

(Hopefully) making things more clear.

Related issue(s)

Related to #1278 (comment)

Testing

  • Checks pass

Checklist

  • Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file. no functional changes

Make explicit the unintuitive reasoning behind this operation.
@victorlin victorlin requested a review from a team August 16, 2023 16:06
@victorlin victorlin self-assigned this Aug 16, 2023
@victorlin victorlin merged commit f98ecef into master Aug 21, 2023
26 checks passed
@victorlin victorlin deleted the victorlin/clarify-filter-query branch August 21, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants