Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations schema updates #1281

Merged
merged 3 commits into from
Aug 20, 2023
Merged

Annotations schema updates #1281

merged 3 commits into from
Aug 20, 2023

Commits on Aug 16, 2023

  1. Update annotations schema to be correct

    The annotations schema is updated to more accurately represent how this
    data is used by Auspice version 2.46.1. Specifically, the strand of the
    'nuc' property is not used by auspice, and start/end coordinates are
    required properties.
    
    Tests are updated because the tests were incorrect.
    
    Currently the annotations section of node-data JSONs are produced by
    `augur ancestral` and `augur translate`. Each adds a 'nuc' property,
    and it's required for Auspice, so I think it's appropriate to make it a
    required property for the schema.
    
    The changes to the schema here are only reflected when parsing node-data
    files, the next commit will make this available for our typical auspice
    JSON validation.
    jameshadfield committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    d6246ca View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. [validate] allow local $refs

    See added comments for details
    jameshadfield committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    37f63b4 View commit details
    Browse the repository at this point in the history
  2. Extend annotations schema

    See <nextstrain/auspice#1684> for the context
    for these additions.
    jameshadfield committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    c530539 View commit details
    Browse the repository at this point in the history