filter: Expose internal Pandas errors from --query
#1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1267 +/- ##
=======================================
Coverage 69.36% 69.36%
=======================================
Files 66 66
Lines 7024 7024
Branches 1708 1708
=======================================
Hits 4872 4872
Misses 1847 1847
Partials 305 305
☔ View full report in Codecov by Sentry. |
Previously, all Pandas error messages were hidden from the user because they were assumed to be cryptic. Turns out, some error messages may be useful - see the functional test change.
victorlin
force-pushed
the
victorlin/filter-query-errors
branch
from
c66edf0
to
d7ca649
Compare
huddlej
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
This looks great! Thank you for the quick fix, @victorlin. Should we make a new patch release once this is merged?
|
@huddlej yes! I plan to do a release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Previously, all Pandas error messages were hidden from the user because they were assumed to be cryptic. Turns out, some error messages may be useful - see the functional test change.
Related issue(s)
Prompted by in-lab discussion with a user.
Testing
What steps should be taken to test the changes you've proposed?
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?
Checklist