Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequency estimation fails with missing data. #582

Open
rneher opened this issue Jun 27, 2020 · 1 comment
Open

Frequency estimation fails with missing data. #582

rneher opened this issue Jun 27, 2020 · 1 comment
Labels
bug Something isn't working priority: low To be resolved after high and moderate priority issues

Comments

@rneher
Copy link
Member

rneher commented Jun 27, 2020

Current Behavior
when the metadata can't be parsed into numerical dates, frequencies fail as reported here:
nextstrain/ncov#446

We need to make sure that frequency estimation either fails or gracefully handles missing data points.

@rneher rneher added the bug Something isn't working label Jun 27, 2020
@rneher
Copy link
Member Author

rneher commented Jun 27, 2020

the problem is here:
https://github.com/nextstrain/augur/blob/master/augur/frequencies.py#L97
when numpy attempts to compute a mean of None.
None is returned from here:
https://github.com/nextstrain/augur/blob/master/augur/utils.py#L132

@trvrb trvrb added the priority: low To be resolved after high and moderate priority issues label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: low To be resolved after high and moderate priority issues
Projects
None yet
Development

No branches or pull requests

2 participants