-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve startup time #472
Comments
@willingc I'll dig into this. |
Just curious, are you seeing it being slow on Linux too? |
I guess the question is how slow is "slow"? Running my processor at 2.4Ghz, it takes 1.073s to run If my laptop processor is running with dynamic frequency scaling, the EDIT: This is with Python 3.7, btw. |
I notice that Ideally, all this code should live |
The specific start case that I was seeing was typing |
@willingc can you post the output of |
Hi @groutr, Whelp in true software fashion it's not slow today. lol Here's the output requested: If you want feel free to close now. |
As another data point, on macOS 2.4 GHz Intel Core i5: |
Thanks @willingc and @jasongrout. I'm going to experiment with restructuring the cli to import things lazily. |
Looks like the help pages are probably the worst case scenario. However, I would argue that if the help pages aren't fast, it gives the impression that the program itself is slow. Fortunately, the help pages are easy to speed up. I was able to drop the time from >1s to about < .1s on my machine. |
Example
|
I can confirm that the issue still exists. Using augur for the first time today and I was surprised at how unresponsive the CLI is. Very unusual for and potentially off-putting. Really shouldn't be hard to fix for the common case of displaying help information. Here's another data point
with the following machine
|
Noting that this is impacting CI run times. Example: the latest scheduled run took 13m43s to complete. The bottleneck is cram tests which take ~11 minutes to run. Some cram tests do take a while, but I suspect a chunk of it is simply startup time. |
Cram tests are so slow. It's particularly painful to iterate on them in local dev. |
Context
Currently on MacOS 10.15.3, the CLI is slow to display after typing
augur
.Description
Investigate if there is an optimization that can be made.
The text was updated successfully, but these errors were encountered: