Skip to content

Conversation

TAG-Epic
Copy link
Member

@TAG-Epic TAG-Epic commented Jul 23, 2023

Issues:

  • No tests
  • Doesn't give you info about what part it failed at, it is only logged.

Why not just use a exception like pynacl does?

I personally prefer:

# This
if not REQUEST_VERIFIER.is_valid(...):
    return {"detail": "Go away"}, 400
    
# Over this
try:
    REQUEST_VERIFIER.verify(...):
except BaseVerificationError:
    return {"detail": "Go away"}, 400

However I am still unsure.

This is based on and superseeds #255

@TAG-Epic TAG-Epic added the type/feature A feature addition label Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature A feature addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant