[stable-3.16] nmc/2025/2003-Folderview_Settings_Dialog_Manual #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memurats
added
custom
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Qt 6.8 now requires macOS 12.0 as per https://doc.qt.io/qt-6.8/macos.html for comparison, Qt 6.7 supported 11.0 and newer: https://doc.qt.io/qt-6.7/macos.html also update the Packages project to refuse to install on anything older than Monterey (12.0) Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
These are informative notifications without any need/possibility to act on immediately -- if a file is not synced it will be visible from the shell integration anyway. An eventual follow-up to this change would be to have a dialogue with an overview of all files that were ignored (including the entry in the ignore list that caused a specific file to be ignored). Closes nextcloud#6712 Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
…ilds Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
This allows the AppImage build to find and load the experimental VFS
plugins, and not crash with:
[ critical plugins /home/user/src/common/vfs.cpp:250 ]: Could not load plugin: not existent or bad metadata "nextclouddevsync_vfs_suffix"
[ fatal default /home/user/src/gui/folderman.cpp:326 ]: Could not load plugin
[1] 72936 IOT instruction (core dumped) ./nextclouddev-master-x86_64.AppImage
Fixes nextcloud#7135
Fixes nextcloud#7194
Fixes nextcloud#7465
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
This step sometimes fails with an error such as: "A timestamp was expected but was not found.". Any code-signing errors will result in the notarisation step to fail. Apparently this might be due to intermittent network issues. Let's just retry codesigning a couple of times in the case it fails ... See also: https://developer.apple.com/documentation/security/resolving-common-notarization-issues#Include-a-secure-timestamp Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
in FilePermissionsRestore, first checks the folder permissions before changing them will avoid useless call changing permissions when not needed Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
will avoid getting a content access denied error because some paths is too long for windows default limit and has to use the special syntax for long path see https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we need platform native separators for file paths that will be used in native Windows platform specific APIs Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
if Readable permissions is missing, do nto try to download the file if a file was downlaoded but Readable permission is now missing, remove it Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
On Linux changing the permissions causes inotify to create a IN_ATTRIB event -- even if the permissions stays the same. Such an event is passed to the filesystem watcher which lets the client schedule a new sync run. In certain conditions, this could happen during every sync run... Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Extra safeguard to ensure that the usage of `FileSystem::setFolderPermissions` won't start a new sync run if FolderWatcher/inotify detects a change in the file metadata... Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…ac-crafter build run Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
A value of `ReallySuppress` will not display a reboot prompt whenever the `ForceReboot` action was run, or whenever a reboot was scheduled (e.g. by `FilesInUse`). Apparently this will not reboot the machine on its own either. `winget` sets this property in its manifest[0], and according to reports in issue nextcloud#5369 this seems to work. See also: https://learn.microsoft.com/en-us/windows/win32/msi/reboot [0]: https://github.com/microsoft/winget-pkgs/blob/0b40904d1480f67d48c6d8e2ac7f27b31aa566c7/manifests/n/Nextcloud/NextcloudDesktop/3.16.5/Nextcloud.NextcloudDesktop.installer.yaml#L16 Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
|
Artifact containing the AppImage: nextcloud-appimage-pr-375.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
memurats
added
Outdated
and removed
approved
build-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stable-3.16 baseline for
#344