Nmc/1980 Empty state #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
e8ec7e5 to
1a55072
Compare
There was a problem hiding this comment.
Isn't this the same file as https://github.com/nextmcloud/android/blob/62ed1a7708c6b1f615e596ce6e9fbcfa34513e27/app/src/main/res/drawable/ic_search.xml
(ic_search.xml in https://github.com/nextmcloud/android/pull/74/files)
If so, I suggest to use the same file on both.
Also do not change names, as any code change can lead to problems later.
Instead simply overwrite in one PR all images/icons.
Author
There was a problem hiding this comment.
@tobiasKaminsky Both icons have different usage.
- ic_search.xml will be used for search icon.
- ic_search_empty.xml and night/ic_search_empty.xml will be used for empty state during search event.
This PR is purely related to handling empty state with related icons and Icons PR(#74) will have all the other icons except the empty state icons so there wont be any code conflict problem.
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
5 times, most recently
from
68ab22d to
f2f8465
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
f2f8465 to
d596f57
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
d596f57 to
7f4ed33
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
7f4ed33 to
2142680
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
2142680 to
52fe81b
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
2 times, most recently
from
5ed57cc to
0bcf802
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
0bcf802 to
1083f5e
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
2 times, most recently
from
efbf695 to
5746c33
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
5746c33 to
bdde5f8
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
bdde5f8 to
f9a84a9
Compare
tobiasKaminsky
force-pushed
the
nmc/1980-empty_state
branch
from
f9a84a9 to
256311f
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
256311f to
90ac677
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
2 times, most recently
from
e2077fc to
0b50af4
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
0b50af4 to
bbd8886
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
2 times, most recently
from
3b356ad to
d674843
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
d674843 to
de894e1
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
de894e1 to
441c855
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
441c855 to
aef9e83
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
aef9e83 to
9f07bf1
Compare
surinder-tsys
force-pushed
the
nmc/1980-empty_state
branch
from
9f07bf1 to
98136eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated empty state icon and text for different screens.