Prevent DOM scrolling on kill shortcut #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed when implementing clojure-mode on a tall page, whenever I tried the kill command (Ctrl-k) the kill would happen correctly but my page would get scrolled down to the bottom. This was because my browser was focusing on the temporary textarea element created in the copy-to-clipboard! function. Adding :preventScroll true fixed the problem for me.
Merged
zampino
added a commit
that referenced
this pull request
Jul 6, 2022
Co-authored-by: Adam Frey <adam@adamfrey.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when using clojure-mode on a tall page, whenever I tried the kill command (Ctrl-k) the kill would happen correctly but my page would get scrolled down to the bottom. This was because my browser was focusing on the temporary textarea element created in the copy-to-clipboard! function. Adding
:preventScroll truefixed the problem for me.