Combine runSubprocessN into a single function #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions can be replicated as follows: runSubprocess(cmd, '.', lib.log) -> runSubprocess(cmd, '.', lib.log) runSubprocess2(cmd, '.', lib.log, output_file) -> runSubprocess(cmd, '.', lib.log, capture_output=output_file) runSubprocess3(cmd, '.', lib.log) -> runSubprocess(cmd, '.', lib.log, capture_output=False) runSubprocess4(cmd, '.', lib.log) -> runSubprocess(cmd, '.', lib.log, only_failed=True) runSubprocess5(cmd, '.', lib.log, input_file, output_file) -> runSubprocess(cmd, '.', lib.log, input=input_file, capture_output=output_file) runSubprocess6(cmd, '.', lib.log, logfile2) -> runSubprocess(cmd, '.', lib.log, capture_output=logfile2, capture_error="STDOUT") runSubprocess7 - didn't replicate, found no uses runSubprocess8(cmd, '.', lib.log, output_file) -> runSubprocess(cmd, '.', lib.log, capture_output=output_file, only_failed=True) A context manager for the subprocess in/out/error was created to allow proper closing if input/output files are used
|
Wow lots of work here -- yes this is something that was sloppy in the code. Let me pull this branch and run some more tests, but code looks good. |
|
fantastic all my local tests passed, thanks @mglubber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for putting together a great tool. I'm using on about 4 different projects now.
When I was tracking down some errors I was having with a run, I found that there are 8 different versions of runSubprocess, which made it a bit difficult to determine what was going on. I've combined them into a single function (and context manager). I ran
funannotate teston the modified version and everything passed successfully.The original functions can be replicated as follows: