Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log out the key that is being retrieved from the deprecated MessageHeaders.get method #4332

Closed
rbeckman-nextgen opened this issue May 11, 2020 · 1 comment · Fixed by #4399
Closed

Log out the key that is being retrieved from the deprecated MessageHeaders.get method #4332

rbeckman-nextgen opened this issue May 11, 2020 · 1 comment · Fixed by #4399
Labels
Fix-Commited Issue fixed and will be available in milestone Internal-Issue-Created An issue has been created in NextGen's internal issue tracker RS-6953 triaged
Milestone
4.0.0

Comments

@rbeckman-nextgen
Copy link
Collaborator

com.mirth.connect.userutil.MessageHeaders#get is deprecated. It logs out a message stating > The get(key) method for retrieving Http headers is deprecated and will soon be removed. Please use getHeader(key) or getHeaderList(key) instead.

These calls are hard to track down for some usages. They would be easier to track down if this method also logged out what key was being requested.

I am attaching a patch with a suggestion.

Imported Issue. Original Details:
Jira Issue Key: MIRTH-4457
Reporter: jbartels
Created: 2019-09-19T13:48:54.000-0700
jonbartels pushed a commit to jonbartels/connect that referenced this issue Jun 25, 2020
https://github.com/nextgenhealthcare/connect/issues/4332
00dcc0a
@jonbartels jonbartels mentioned this issue Jun 25, 2020
Merged
@cturczynskyj cturczynskyj added the closed-due-to-inactivity This is being closed due to age. If this is still an issue, comment and we can reopen. label Mar 1, 2021
@pladesma pladesma closed this as completed Mar 1, 2021
@cturczynskyj cturczynskyj linked a pull request Mar 1, 2021 that will close this issue
Log out the key that is being retrieved from the deprecated MessageHeaders.get method #4332 #4399
Merged
@cturczynskyj cturczynskyj removed the closed-due-to-inactivity This is being closed due to age. If this is still an issue, comment and we can reopen. label Mar 1, 2021
@cturczynskyj
Copy link
Collaborator

Found open PR

@cturczynskyj cturczynskyj reopened this Mar 1, 2021
@cturczynskyj cturczynskyj added Internal-Issue-Created An issue has been created in NextGen's internal issue tracker RS-6953 triaged labels Oct 7, 2021
cturczynskyj added a commit that referenced this issue Feb 3, 2022
@cturczynskyj
Merge pull request #4399 from jonbartels/development
99ade7d 
Log out the key that is being retrieved from the deprecated MessageHeaders.get method #4332
@cturczynskyj cturczynskyj added this to the 3.13.0 milestone Feb 7, 2022
cturczynskyj pushed a commit that referenced this issue Feb 7, 2022
Pull request #507: Pr4399 log key from deprecated method
87866b4 
Merge in MC/connect from pr4399-log-key-from-deprecated-method to development

* commit 'd0b5f9996959a92ffdde8f149a3c6b4b6c5900ff':
  ROCKSOLID-7524 Change Template from deprecated get() to getHeader()
  #4332
@cturczynskyj cturczynskyj added the Fix-Commited Issue fixed and will be available in milestone label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fix-Commited Issue fixed and will be available in milestone Internal-Issue-Created An issue has been created in NextGen's internal issue tracker RS-6953 triaged
Projects
None yet
Milestone
4.0.0
3 participants
@pladesma @cturczynskyj @rbeckman-nextgen