-
Notifications
You must be signed in to change notification settings - Fork 263
Improvements to Side Quest: Metadata #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vdauwera
wants to merge
14
commits into
master
Choose a base branch
from
gvda-sidequests-metadata-tweaks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Nextflow linting complete! ❌ 5 files had 33 errors 💡 Tip: Click filename locations to go directly to that code. View all 33 issues
View formatting changes
|
More logical to provide the process as a module and reorder the steps so we customize the character right off the bat (shows passing the metadata as an argument) then fiddling with the output directories as a way to use metadata inside the process (though we'll have to think how that changes once we introduce workflow-level outputs, maybe switch to filename customization)
Collaborator
Author
|
This is ready for review. I made some important changes to section 3 to streamline and explain more clearly what was going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on 2025 teaching experience
Mainly improvements to instructions and consistent formatting. More detail across the board. Reordering section 3 to make more intuitive sense (see commit notes)